gianm commented on a change in pull request #8919: fix bug with sqlOuterLimit,
use sqlOuterLimit in web console
URL: https://github.com/apache/incubator-druid/pull/8919#discussion_r349217078
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -809,6 +809,39 @@ public void
testSelectStarFromSelectSingleColumnWithLimitDescending() throws Exc
new Object[]{"def"}
)
);
+
+ List<Object[]> expected;
+ if (NullHandling.replaceWithDefault()) {
+ expected = ImmutableList.of(
+ new Object[]{"", 1L},
+ new Object[]{"def", 1L}
+ );
+ } else {
+ expected = ImmutableList.of(
+ new Object[]{"def", 1L},
+ new Object[]{"abc", 1L}
+ );
+ }
+ testQuery(
Review comment:
I think it's best to have one `testQuery` call per test method. So, I'd
create a new method for this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
