jihoonson commented on a change in pull request #8903: S3 input source
URL: https://github.com/apache/incubator-druid/pull/8903#discussion_r349802413
##########
File path: core/src/main/java/org/apache/druid/data/input/InputSource.java
##########
@@ -78,6 +78,6 @@
InputSourceReader reader(
InputRowSchema inputRowSchema,
@Nullable InputFormat inputFormat,
- File temporaryDirectory
+ @Nullable File temporaryDirectory
Review comment:
Is this nullable now? I think it shouldn't be nullable if it's null only in
unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
