jihoonson commented on a change in pull request #8903: S3 input source
URL: https://github.com/apache/incubator-druid/pull/8903#discussion_r350358773
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentPuller.java
##########
@@ -84,7 +81,7 @@ public S3DataSegmentPuller(ServerSideEncryptingAmazonS3
s3Client)
try {
org.apache.commons.io.FileUtils.forceMkdir(outDir);
- final URI uri = URI.create(StringUtils.format("s3://%s/%s",
s3Coords.bucket, s3Coords.path));
+ final URI uri = URI.create(StringUtils.format("s3://%s/%s",
s3Coords.getBucket(), s3Coords.getPath()));
Review comment:
This is not a regression and so doesn't have to be fixed in this PR. It's up
to the author in this case.
> IMHO we should always leave code better than we found it. Small bugs like
this are not worth putting into an issue, and will likely never get worked on,
but some poor soul somewhere on the interwebs will run into it and bang their
head against it.
I don't think this will be happening for this bug. This bug is pretty
critical and should be fixed as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
