clintropolis commented on a change in pull request #8903: S3 input source URL: https://github.com/apache/incubator-druid/pull/8903#discussion_r350479419
########## File path: extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSource.java ########## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.data.input.s3; + +import com.amazonaws.services.s3.model.S3ObjectSummary; +import com.fasterxml.jackson.annotation.JacksonInject; +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; +import org.apache.druid.data.input.AbstractInputSource; +import org.apache.druid.data.input.InputFormat; +import org.apache.druid.data.input.InputRowSchema; +import org.apache.druid.data.input.InputSourceReader; +import org.apache.druid.data.input.InputSplit; +import org.apache.druid.data.input.SplitHintSpec; +import org.apache.druid.data.input.impl.CloudObjectLocation; +import org.apache.druid.data.input.impl.InputEntityIteratingReader; +import org.apache.druid.data.input.impl.SplittableInputSource; +import org.apache.druid.java.util.common.IAE; +import org.apache.druid.storage.s3.S3Utils; +import org.apache.druid.storage.s3.ServerSideEncryptingAmazonS3; + +import javax.annotation.Nullable; +import java.io.File; +import java.net.URI; +import java.util.ArrayList; +import java.util.List; +import java.util.Objects; +import java.util.stream.Stream; +import java.util.stream.StreamSupport; + +public class S3InputSource extends AbstractInputSource implements SplittableInputSource<CloudObjectLocation> +{ + private static final int MAX_LISTING_LENGTH = 1024; + + private final ServerSideEncryptingAmazonS3 s3Client; + private final List<URI> uris; + private final List<URI> prefixes; + private final List<CloudObjectLocation> objects; + + @JsonCreator + public S3InputSource( + @JacksonInject ServerSideEncryptingAmazonS3 s3Client, + @JsonProperty("uris") @Nullable List<URI> uris, + @JsonProperty("prefixes") @Nullable List<URI> prefixes, + @JsonProperty("objects") @Nullable List<CloudObjectLocation> objects + ) + { + this.s3Client = Preconditions.checkNotNull(s3Client, "s3Client"); + this.uris = uris == null ? new ArrayList<>() : uris; + this.prefixes = prefixes == null ? new ArrayList<>() : prefixes; Review comment: burned again for initially starting by porting over the `S3StaticFirehoseFactory`, reworked this to use nulls... though as I'm writing this comment I realize I should probably treat empties the same as null and not consider that invalid... will fix PR again ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
