clintropolis commented on a change in pull request #8903: S3 input source
URL: https://github.com/apache/incubator-druid/pull/8903#discussion_r350508926
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3DataSegmentPuller.java
##########
@@ -84,7 +81,7 @@ public S3DataSegmentPuller(ServerSideEncryptingAmazonS3
s3Client)
try {
org.apache.commons.io.FileUtils.forceMkdir(outDir);
- final URI uri = URI.create(StringUtils.format("s3://%s/%s",
s3Coords.bucket, s3Coords.path));
+ final URI uri = URI.create(StringUtils.format("s3://%s/%s",
s3Coords.getBucket(), s3Coords.getPath()));
Review comment:
I went ahead and fixed this for most of S3 by refactoring to use
`CloudObjectLocation` to ensure URI handling is good, though the footprint of
this PR has grown a lot, which is what I was worried about. In some sense, this
is sort of related to the work done in #6761. I have opened #8941 to finish the
remaining issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
