jon-wei commented on a change in pull request #8870: Additional Kinesis
resharding fixes
URL: https://github.com/apache/incubator-druid/pull/8870#discussion_r350566912
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -970,6 +971,29 @@ public void onSuccess(SegmentsAndMetadata
publishedSegmentsAndMetadata)
Preconditions.checkNotNull(publishedSegmentsAndMetadata.getCommitMetadata(),
"commitMetadata")
);
+ if (supportsPartitionExpiration() &&
publishedSegmentsAndMetadata.getSegments().isEmpty()) {
+ // we didn't publish anything, check if we have any closed
partitions that we should tell the
+ // supervisor about so that it stop assigning them to later
tasks.
+ log.info("We published nothing! Checking sequence metadata for
closed shards: " + sequenceMetadata);
Review comment:
This area has been removed, the metadata commit is now handled in the main
publishing logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
