pzhdfy commented on a change in pull request #6988: [Improvement] historical
fast restart by lazy load columns metadata(20X faster)
URL: https://github.com/apache/incubator-druid/pull/6988#discussion_r351276943
##########
File path:
processing/src/main/java/org/apache/druid/segment/SimpleQueryableIndex.java
##########
@@ -42,19 +44,20 @@
private final List<String> columnNames;
private final Indexed<String> availableDimensions;
private final BitmapFactory bitmapFactory;
- private final Map<String, ColumnHolder> columns;
+ private final Map<String, Supplier<ColumnHolder>> columns;
private final SmooshedFileMapper fileMapper;
@Nullable
private final Metadata metadata;
- private final Map<String, DimensionHandler> dimensionHandlers;
+ private final Supplier<Map<String, DimensionHandler>> dimensionHandlers;
public SimpleQueryableIndex(
Interval dataInterval,
Indexed<String> dimNames,
BitmapFactory bitmapFactory,
- Map<String, ColumnHolder> columns,
+ Map<String, Supplier<ColumnHolder>> columns,
SmooshedFileMapper fileMapper,
- @Nullable Metadata metadata
+ @Nullable Metadata metadata,
+ boolean lazy
Review comment:
I think keep current is acceptable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
