jnaous commented on issue #9111: Add HashJoinSegment, a virtual segment for joins. URL: https://github.com/apache/druid/pull/9111#issuecomment-573150825 I've found it tough reviewing this PR. I think it could have been broken down into a few other PRs. For example: 1. The refactor of class/method name changes 2. The implementation of all the factories for the selectors 3. The Join logic 4. The IndexedTable implementation and its related pieces
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
