gianm commented on issue #9111: Add HashJoinSegment, a virtual segment for joins. URL: https://github.com/apache/druid/pull/9111#issuecomment-573164062 > If you're not going to add unit tests, I think we should have a coverage check to make sure that the inputs to the functional tests end up testing all branches of the code... Sounds like a good idea to me. IMO it isn't worth unit testing every single class, and can even be counter-productive (adds to the amount of work it takes to refactor things later). So I like the idea of pairing functional tests with coverage checks. That being said, some of the examples you pointed out would be good to add unit tests for, so I'll go through and add a few more. I probably won't have a chance to do this today, but I'll try to get to it soon.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
