gianm commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r365986119
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/vector/VectorValueMatcherColumnProcessorFactory.java
##########
@@ -19,55 +19,55 @@
package org.apache.druid.query.filter.vector;
-import org.apache.druid.query.dimension.VectorColumnStrategizer;
+import org.apache.druid.query.dimension.VectorColumnProcessorFactory;
import org.apache.druid.segment.vector.MultiValueDimensionVectorSelector;
import org.apache.druid.segment.vector.SingleValueDimensionVectorSelector;
import org.apache.druid.segment.vector.VectorValueSelector;
-public class VectorValueMatcherColumnStrategizer implements
VectorColumnStrategizer<VectorValueMatcherFactory>
+public class VectorValueMatcherColumnProcessorFactory implements
VectorColumnProcessorFactory<VectorValueMatcherFactory>
{
- private static final VectorValueMatcherColumnStrategizer INSTANCE = new
VectorValueMatcherColumnStrategizer();
+ private static final VectorValueMatcherColumnProcessorFactory INSTANCE = new
VectorValueMatcherColumnProcessorFactory();
Review comment:
IMO objects that are both static and stateful/configurable are an
abomination against all that is good and natural in the world. I would only
want to go with the `static final` pattern for stateless objects that don't
accept any runtime configuration.
I think for those kinds of objects, `static final` is reasonable, and
preferred vs. Guice since it's simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
