gianm commented on a change in pull request #9111: Add HashJoinSegment, a virtual segment for joins. URL: https://github.com/apache/druid/pull/9111#discussion_r365986839
########## File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryHelper.java ########## @@ -42,6 +42,7 @@ import org.apache.druid.query.aggregation.AggregatorFactory; import org.apache.druid.query.aggregation.PostAggregator; import org.apache.druid.query.dimension.DimensionSpec; +import org.apache.druid.segment.RowBasedColumnSelectorFactory; Review comment: It's needed now because it moved out of the `org.apache.druid.query.groupby` package. Anyway, we have a Travis step that verifies there aren't any unneeded imports, so there's no need to scan for them visually. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
