gianm commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r366011445
##########
File path:
processing/src/main/java/org/apache/druid/segment/RowBasedColumnSelectorFactory.java
##########
@@ -53,12 +45,20 @@
public class RowBasedColumnSelectorFactory<T> implements ColumnSelectorFactory
{
- public interface RowAdapter<T>
+ private static final RowAdapter<? extends Row> STANDARD_ROW_ADAPTER = new
RowAdapter<Row>()
Review comment:
I feel this way about it —
https://github.com/apache/druid/pull/9111#discussion_r365986119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
