clintropolis commented on a change in pull request #9187: Implement ANY
aggregator
URL: https://github.com/apache/druid/pull/9187#discussion_r367233250
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -1297,6 +1301,46 @@ public void testLatestAggregators() throws Exception
);
}
+ // This test the on-heap version of the AnyAggregator
(Double/Float/Long/String)
+ @Test
+ public void testAnyAggregator() throws Exception
Review comment:
nit: It would probably be worth adding an additional test that tests numeric
columns agains `druid.numfoo` table since it contains numeric columns that have
null values when run in sql compatible null mode, and also tests for ordering
by each 'any' aggregator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
