clintropolis commented on a change in pull request #9187: Implement ANY aggregator URL: https://github.com/apache/druid/pull/9187#discussion_r367230483
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/any/DoubleAnyBufferAggregator.java ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.any; + +import org.apache.druid.query.aggregation.BufferAggregator; +import org.apache.druid.query.aggregation.NullableNumericAggregator; +import org.apache.druid.query.aggregation.NullableNumericAggregatorFactory; +import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector; +import org.apache.druid.segment.BaseDoubleColumnValueSelector; + +import java.nio.ByteBuffer; + +/** + * This Aggregator is created by the {@link DoubleAnyAggregatorFactory} which extends from + * {@link NullableNumericAggregatorFactory}. If null needs to be handle, then {@link NullableNumericAggregatorFactory} + * will wrap this aggregator in {@link NullableNumericAggregator} and can handle all null in that class. + * Hence, no null will ever be pass into this aggregator from the valueSelector. + */ +public class DoubleAnyBufferAggregator implements BufferAggregator +{ + private static final byte BYTE_FLAG_IS_NOT_SET = 0; + private static final byte BYTE_FLAG_IS_SET = 1; + private static final double NULL_VALUE = 0; + private final BaseDoubleColumnValueSelector valueSelector; + + public DoubleAnyBufferAggregator(BaseDoubleColumnValueSelector valueSelector) + { + this.valueSelector = valueSelector; + } + + @Override + public void init(ByteBuffer buf, int position) + { + buf.put(position, BYTE_FLAG_IS_NOT_SET); + buf.putDouble(position + Byte.BYTES, NULL_VALUE); Review comment: instead of `NULL_VALUE` maybe use `NullHandling.ZERO_DOUBLE` or like just 0 since this is the only place this is used ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
