suneet-s opened a new pull request #9200: Optimize JoinCondition matching
URL: https://github.com/apache/druid/pull/9200
 
 
   ### Description
   
   The LookupJoinMatcher needs to check if a condition is always true or false
   multiple times. This can be pre-computed to speed up the match checking
   
   This change reduces the time it takes to perform a for joining on a long key
   from ~ 36 ms/op to 23 ms/ op
   
   ![Screen Shot 2020-01-16 at 3 34 16 
PM](https://user-images.githubusercontent.com/44787917/72571945-e6a31d00-3875-11ea-8f88-6cecc8a9ee1b.png)
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to