jihoonson commented on a change in pull request #9183: fix topn aggregation on numeric columns with null values URL: https://github.com/apache/druid/pull/9183#discussion_r368107798
########## File path: processing/src/main/java/org/apache/druid/query/topn/types/TopNColumnSelectorStrategyFactory.java ########## @@ -23,10 +23,14 @@ import org.apache.druid.java.util.common.IAE; import org.apache.druid.query.dimension.ColumnSelectorStrategyFactory; import org.apache.druid.segment.ColumnValueSelector; +import org.apache.druid.segment.DimensionHandlerUtils; import org.apache.druid.segment.column.ColumnCapabilities; import org.apache.druid.segment.column.ValueType; -public class TopNColumnSelectorStrategyFactory implements ColumnSelectorStrategyFactory<TopNColumnSelectorStrategy> +import java.util.function.Function; + +public class TopNColumnSelectorStrategyFactory Review comment: nit: `TopNColumnAggregatesProcessorFactory`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
