clintropolis commented on a change in pull request #9183: fix topn aggregation
on numeric columns with null values
URL: https://github.com/apache/druid/pull/9183#discussion_r368126673
##########
File path:
processing/src/main/java/org/apache/druid/query/topn/BaseTopNAlgorithm.java
##########
@@ -79,7 +78,7 @@ public void run(
@Nullable TopNQueryMetrics queryMetrics
)
{
- if (params.getCardinality() !=
TopNColumnSelectorStrategy.CARDINALITY_UNKNOWN) {
+ if (params.getCardinality() != TopNParams.CARDINALITY_UNKNOWN) {
Review comment:
I agree but do not want to settle this up in this PR, part of the problem is
that different parts of the code use different values to indicate unknown
cardinality...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
