suneet-s commented on a change in pull request #9247: Add JoinableFactory interface and use it in the query stack. URL: https://github.com/apache/druid/pull/9247#discussion_r370755271
########## File path: server/src/main/java/org/apache/druid/segment/join/DefaultJoinableFactory.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.join; + +import com.google.inject.Inject; +import org.apache.druid.query.DataSource; + +import java.util.Collections; +import java.util.List; +import java.util.Optional; + +public class DefaultJoinableFactory implements JoinableFactory Review comment: javadocs please. I'm a little confused why this is the "Default" and not just a delegating factory. Also since this is just one delegate, I think it would be easier to follow if there was just one `factory` instead of `factories`. When we add support for multiple factories, we can change this and think about how to decide precedence if more than one factory can build a joinable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
