gianm commented on a change in pull request #9247: Add JoinableFactory
interface and use it in the query stack.
URL: https://github.com/apache/druid/pull/9247#discussion_r370739195
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegment.java
##########
@@ -50,15 +49,9 @@ public HashJoinSegment(
this.baseSegment = baseSegment;
this.clauses = clauses;
- // Verify no clauses would shadow the special __time field.
- for (JoinableClause clause : clauses) {
- if (clause.includesColumn(ColumnHolder.TIME_COLUMN_NAME)) {
Review comment:
Yes, we do, although that's not what this means. This same check is still
being applied, but in the constructor of JoinableClause (it calls
`Joinables.validatePrefix`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
