jihoonson commented on a change in pull request #9271: Make JoinableFactory an 
extension point
URL: https://github.com/apache/druid/pull/9271#discussion_r371663752
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/segment/join/JoinableFactory.java
 ##########
 @@ -19,13 +19,17 @@
 
 package org.apache.druid.segment.join;
 
+import com.google.common.annotations.Beta;
+import org.apache.druid.guice.annotations.ExtensionPoint;
 import org.apache.druid.query.DataSource;
 
 import java.util.Optional;
 
 /**
  * Utility for creating {@link Joinable} objects.
  */
+@Beta
 
 Review comment:
   How does it make different from other extension points without `@Beta`? Does 
it mean this extension point can change in breaking ways even between minor 
releases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to