jihoonson commented on a change in pull request #9271: Make JoinableFactory an
extension point
URL: https://github.com/apache/druid/pull/9271#discussion_r371972823
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/JoinableFactory.java
##########
@@ -19,13 +19,17 @@
package org.apache.druid.segment.join;
+import com.google.common.annotations.Beta;
+import org.apache.druid.guice.annotations.ExtensionPoint;
import org.apache.druid.query.DataSource;
import java.util.Optional;
/**
* Utility for creating {@link Joinable} objects.
*/
+@Beta
Review comment:
> It may also be that this ExtensionPoint goes away completely in a near
future version, so core extensions should not rely on this.
Would you please add this to the javadoc?
> so core extensions should not rely on this.
Hmm, would you elaborate more on this? Are you referring to the Druid core
extensions here? Per my understanding, the extension point and public api
interfaces are more for third party extensions which are neither core nor
contrib extensions. I think it doesn’t matter much whether the core or contrib
extensions rely on some beta extension points or not because we will fix the
code for them by ourselves. But the third party extensions are not in the Druid
repository but in their own and so changed in extension points and apis should
be noticed.
How about making this interface as an extension point once all dusts settle
down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
