ccaominh commented on a change in pull request #9274: Refactoring some codes around ingestion URL: https://github.com/apache/druid/pull/9274#discussion_r372145227
########## File path: core/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpecFactory.java ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.timeline.partition; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.databind.ObjectMapper; + +import javax.annotation.Nullable; +import java.util.Objects; + +public class SingleDimensionShardSpecFactory implements ShardSpecFactory +{ + private final String partitionDimension; + private final PartitionBoundaries partitionBoundaries; + + @JsonCreator + public SingleDimensionShardSpecFactory( + @JsonProperty("partitionDimension") String partitionDimension, + @JsonProperty("partitionBoundaries") PartitionBoundaries partitionBoundaries + ) + { + this.partitionDimension = partitionDimension; + this.partitionBoundaries = partitionBoundaries; + } + + @JsonProperty + public String getPartitionDimension() + { + return partitionDimension; + } + + @JsonProperty + public PartitionBoundaries getPartitionBoundaries() + { + return partitionBoundaries; + } + + @Override + public ShardSpec create(ObjectMapper objectMapper, @Nullable ShardSpec specOfPreviousMaxPartitionId) + { + final int partitionId; + if (specOfPreviousMaxPartitionId != null) { + assert specOfPreviousMaxPartitionId instanceof SingleDimensionShardSpec; + final SingleDimensionShardSpec prevSpec = (SingleDimensionShardSpec) specOfPreviousMaxPartitionId; + partitionId = prevSpec.getPartitionNum() + 1; + } else { + partitionId = 0; + } + return create(objectMapper, partitionId); + } + + @Override + public ShardSpec create(ObjectMapper objectMapper, int partitionId) + { + // TODO: numBuckets should be added to SingleDimensionShardSpec in a follow-up PR. + return new SingleDimensionShardSpec( + partitionDimension, + partitionBoundaries.get(partitionId), + partitionBoundaries.get(partitionId + 1), + partitionId + ); + } + + @Override + public Class<? extends ShardSpec> getShardSpecClass() + { + return SingleDimensionShardSpec.class; + } + + @Override + public boolean equals(Object o) + { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + SingleDimensionShardSpecFactory that = (SingleDimensionShardSpecFactory) o; + return Objects.equals(partitionDimension, that.partitionDimension) && + Objects.equals(partitionBoundaries, that.partitionBoundaries); Review comment: `PartitionBoundaries` should probably override `equals` for this. Can use `EqualsVerifier` to add a unit test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
