ccaominh commented on a change in pull request #9274: Refactoring some codes
around ingestion
URL: https://github.com/apache/druid/pull/9274#discussion_r372153616
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/SegmentAllocator.java
##########
@@ -21,25 +21,32 @@
import org.apache.druid.data.input.InputRow;
+import javax.annotation.Nullable;
import java.io.IOException;
public interface SegmentAllocator
{
/**
- * Allocates a new segment for a given timestamp.
+ * Allocates a new segment for a given timestamp. Even though its name is
"allocate", this method is actually
Review comment:
Thanks for the additional helpful comments!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
