ccaominh commented on a change in pull request #9274: Refactoring some codes
around ingestion
URL: https://github.com/apache/druid/pull/9274#discussion_r373794236
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialHashSegmentGenerateTask.java
##########
@@ -158,17 +164,24 @@ private HashPartitionStat
createPartitionStat(TaskToolbox toolbox, DataSegment s
);
}
- private Map<Interval, Pair<ShardSpecFactory, Integer>> createShardSpecs()
+ /**
+ * Creates shard specs based on the given configurations. The return value
is a map between intervals created
+ * based on the segment granularity and the shard specs to be created.
+ * Note that the shard specs to be created is a pair of {@link
PartialShardSpec} and number of segments per interval
+ * and filled only when {@link #isGuaranteedRollup} = true. Otherwise, the
return value contains only the set of
+ * intervals generated based on the segment granularity.
+ */
+ public static HashPartitionAnalysis
createHashPartitionAnalysisFromPartitionsSpec(
Review comment:
Is it worth adding a unit test for this method now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
