suneet-s commented on a change in pull request #9306: implement Azure
InputSource reader and deprecate Azure FireHose
URL: https://github.com/apache/druid/pull/9306#discussion_r374405209
##########
File path:
extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorageDruidModule.java
##########
@@ -91,6 +96,16 @@ public void configure(Binder binder)
Binders.taskLogsBinder(binder).addBinding(SCHEME).to(AzureTaskLogs.class);
JsonConfigProvider.bind(binder, "druid.indexer.logs",
AzureTaskLogsConfig.class);
binder.bind(AzureTaskLogs.class).in(LazySingleton.class);
+ binder.install(new FactoryModuleBuilder()
+ .build(AzureByteSourceFactory.class));
+ binder.install(new FactoryModuleBuilder()
+ .build(AzureEntityFactory.class));
+ binder.install(new FactoryModuleBuilder()
+ .build(AzureCloudBlobIteratorFactory.class));
+ binder.install(new FactoryModuleBuilder()
+ .build(AzureCloudBlobIterableFactory.class));
+ binder.install(new FactoryModuleBuilder()
+ .build(ListBlobItemDruidFactory.class));
Review comment:
ModuleTests to ensure the factories are injected and can create their
objects?
Look at this PR - #9279 I've added a bunch of module tests with mocks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
