suneet-s commented on a change in pull request #9279: Guicify druid sql module URL: https://github.com/apache/druid/pull/9279#discussion_r374440751
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSqlSchema.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.schema; + +import com.google.inject.Inject; +import org.apache.calcite.schema.Schema; + +/** + * The schema for druid tables to be accessible via sql. + */ +class DruidSqlSchema implements DruidCalciteSchema Review comment: I don't like `Provider` because that's a guice thing and I'd expect it to have a method that returns an object, but this interface returns 2 things and it doesn't implement Provider<T> How about * `<Druid>Schema` which provides the implementation that Calcite needs to get tables * `CalciteSubSchema` which is an interface containing a name and a `Schema` so that it can be registered to a Root Schema(`SchemaPlus`) * `<System>SubSchema` the implementation of the `CalciteSubSchema` interface for appropriate `<System>Schema` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
