gianm commented on a change in pull request #9279: Guicify druid sql module URL: https://github.com/apache/druid/pull/9279#discussion_r374819636
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/view/DruidViewMacroFactory.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.view; + +import org.apache.druid.server.security.Escalator; +import org.apache.druid.sql.calcite.planner.PlannerFactory; + +/** + * A factory to create a {@link DruidViewMacro} that is used by Guice for Assisted injection. + */ +public interface DruidViewMacroFactory +{ + /** + * Creates an instance of {@link DruidViewMacro} + */ + DruidViewMacro create(PlannerFactory plannerFactory, Escalator escalator, String viewSql); Review comment: Well, okay, I'm fine with keeping it this way. It seems a little convoluted but at least I learned something about Guice while reviewing it. Maybe consider adding some comments about what the purpose of all the indirection is, so future code-archaeologists can understand the intent behind it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
