jihoonson commented on a change in pull request #9224: Create new dynamic
config to pause coordinator helpers when needed
URL: https://github.com/apache/druid/pull/9224#discussion_r375117357
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -678,9 +678,20 @@ public void run()
.withEmitter(emitter)
.withBalancerStrategy(balancerStrategy)
.build();
+
+ boolean coordinationPaused =
getDynamicConfigs().getPauseCoordination();
+ if (coordinationPaused && coordLeaderSelector.isLeader()) {
Review comment:
I think this `if` clause should check `startingLeaderCounter ==
coordLeaderSelector.localTerm()` as well as in the below `if` clause. Or maybe,
this log can be just printed when the dynamic configuration is updated. Also we
are trying to reduce the amount of logs. Do you think it's worth to be the info
level? Or can it be the debug level?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
