capistrant commented on a change in pull request #9224: Create new dynamic
config to pause coordinator helpers when needed
URL: https://github.com/apache/druid/pull/9224#discussion_r375366919
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -678,9 +678,20 @@ public void run()
.withEmitter(emitter)
.withBalancerStrategy(balancerStrategy)
.build();
+
+ boolean coordinationPaused =
getDynamicConfigs().getPauseCoordination();
+ if (coordinationPaused && coordLeaderSelector.isLeader()) {
Review comment:
I agree that this can be flipped to a debug log. It was nice to have it as
info for our initial testing to make sure everything was squared away. I will
swap to debug and add to the conditional check to cover the case you mentioned.
Now that we know everything works, admins will just need to reference the
dynamic config instead of logs for clarity on the state of this (which seems
like better admin practice anyways).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
