jihoonson commented on issue #9057: [new feature] Add HBase2 Indexer URL: https://github.com/apache/druid/pull/9057#issuecomment-582303506 BTW, @mini666 @dkhwangbo have you guys had a chance to look at the new [InputSource](https://github.com/apache/druid/blob/master/core/src/main/java/org/apache/druid/data/input/InputSource.java#L55) interface? IIRC, this PR adds a new Firehose for HBase and I think it's ok because this PR was written before the new interface was added. However, the new InputSource interface does make more sense than Firehose and probably easier to implement for HBase as well. I think adding InputSource implementations would be a nice follow-up PR. :slightly_smiling_face:
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
