suneet-s commented on a change in pull request #9306: implement Azure
InputSource reader and deprecate Azure FireHose
URL: https://github.com/apache/druid/pull/9306#discussion_r376567470
##########
File path:
extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorage.java
##########
@@ -49,7 +57,7 @@ public AzureStorage(
this.cloudBlobClient = cloudBlobClient;
}
- public List<String> emptyCloudBlobDirectory(final String containerName,
final String virtualDirPath)
+ public List<String> emptyCloudBlobDirectory(String containerName, final
String virtualDirPath)
Review comment:
we're not changing the containerName in this function are we? I think it's
confusing if one parameter is marked as final and the other isn't when both are
in fact final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
