suneet-s commented on a change in pull request #9306: implement Azure InputSource reader and deprecate Azure FireHose URL: https://github.com/apache/druid/pull/9306#discussion_r376572129
########## File path: extensions-contrib/azure-extensions/src/test/java/org/apache/druid/data/input/azure/AzureEntityTest.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.data.input.azure; + +import com.google.common.base.Predicate; +import org.apache.commons.io.input.NullInputStream; +import org.apache.druid.data.input.impl.CloudObjectLocation; +import org.apache.druid.storage.azure.AzureByteSource; +import org.apache.druid.storage.azure.AzureByteSourceFactory; +import org.apache.druid.storage.azure.AzureUtils; +import org.easymock.EasyMock; +import org.easymock.EasyMockSupport; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +import java.io.IOException; +import java.io.InputStream; +import java.net.URI; + +public class AzureEntityTest extends EasyMockSupport +{ + private static final String CONTAINER_NAME = "container"; + private static final String BLOB_NAME = "blob"; + private static final int OFFSET = 20; + private static final InputStream INPUT_STREAM = new NullInputStream(OFFSET); + private static final IOException IO_EXCEPTION = new IOException(); + private static final URI ENTITY_URI; + + private CloudObjectLocation location; + private AzureByteSourceFactory byteSourceFactory; + private AzureByteSource byteSource; + + private AzureEntity azureEntity; + + static { + try { + ENTITY_URI = new URI(AzureInputSource.SCHEME + "://" + CONTAINER_NAME + "/" + BLOB_NAME); + } + catch (Exception e) { + throw new RuntimeException(e); + } + } + + @Before + public void setup() + { + location = createMock(CloudObjectLocation.class); + byteSourceFactory = createMock(AzureByteSourceFactory.class); + byteSource = createMock(AzureByteSource.class); + } + + @Test + public void test_getUri_returnsLocationUri() + { + EasyMock.expect(location.getBucket()).andReturn(CONTAINER_NAME); + EasyMock.expect(location.getPath()).andReturn(BLOB_NAME); + EasyMock.expect(byteSourceFactory.create(CONTAINER_NAME, BLOB_NAME)).andReturn(byteSource); + EasyMock.expect(location.toUri(AzureInputSource.SCHEME)).andReturn(ENTITY_URI); + replayAll(); + + azureEntity = new AzureEntity(location, byteSourceFactory); + + URI actualUri = azureEntity.getUri(); + Assert.assertEquals(ENTITY_URI, actualUri); + + verifyAll(); + + } + + @Test + public void test_readFrom_returnsExpectedStream() throws Exception + { + EasyMock.expect(location.getBucket()).andReturn(CONTAINER_NAME); + EasyMock.expect(location.getPath()).andReturn(BLOB_NAME); + EasyMock.expect(byteSource.openStream(OFFSET)).andReturn(INPUT_STREAM); + EasyMock.expect(byteSourceFactory.create(CONTAINER_NAME, BLOB_NAME)).andReturn(byteSource); + replayAll(); + + azureEntity = new AzureEntity(location, byteSourceFactory); + + InputStream actualInputStream = azureEntity.readFrom(OFFSET); + Assert.assertSame(INPUT_STREAM, actualInputStream); + } + + @Test + public void test_readFrom_throwsIOException_propogatesError() + { + try { + EasyMock.expect(location.getBucket()).andReturn(CONTAINER_NAME); + EasyMock.expect(location.getPath()).andReturn(BLOB_NAME); + EasyMock.expect(byteSource.openStream(OFFSET)).andThrow(IO_EXCEPTION); + EasyMock.expect(byteSourceFactory.create(CONTAINER_NAME, BLOB_NAME)).andReturn(byteSource); + replayAll(); + + azureEntity = new AzureEntity(location, byteSourceFactory); + azureEntity.readFrom(OFFSET); + } + catch (IOException e) { + verifyAll(); + } + } + + @Test + public void test_getPath_returnsLocationPath() + { + EasyMock.expect(location.getBucket()).andReturn(CONTAINER_NAME); + EasyMock.expect(location.getPath()).andReturn(BLOB_NAME).atLeastOnce(); + EasyMock.expect(byteSourceFactory.create(CONTAINER_NAME, BLOB_NAME)).andReturn(byteSource); + replayAll(); + + azureEntity = new AzureEntity(location, byteSourceFactory); + String actualPath = azureEntity.getPath(); + + Assert.assertEquals(BLOB_NAME, actualPath); + verifyAll(); + } + + @Test + public void test_getRetryCondition_returnsExpectedRetryCondition() + { + EasyMock.expect(location.getBucket()).andReturn(CONTAINER_NAME); + EasyMock.expect(location.getPath()).andReturn(BLOB_NAME).atLeastOnce(); + EasyMock.expect(byteSourceFactory.create(CONTAINER_NAME, BLOB_NAME)).andReturn(byteSource); + replayAll(); + + azureEntity = new AzureEntity(location, byteSourceFactory); + Predicate<Throwable> actualRetryCondition = azureEntity.getRetryCondition(); + Assert.assertSame(AzureUtils.AZURE_RETRY, actualRetryCondition); + } +} Review comment: nit: Add a test for readFromStart ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
