suneet-s opened a new pull request #9339: IntelliJ inspections cleanup URL: https://github.com/apache/druid/pull/9339 * Standard Charset object can be used * Redundant Collection.addAll() call * String literal concatenation missing whitespace * Statement with empty body * Redundant Collection operation * StringBuilder can be replaced with String * Type parameter hides visible type Reading through the warnings, none of these appear terribly bad. The type parameter warning is a good one to be an error since it's usually a mistake in parameterizing the types by the dev. Empty statement bodies are also good errors to flag since it's possible an empty body was unintentional.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
