suneet-s commented on a change in pull request #9356: Add Azure config options for segment prefix and max listing length URL: https://github.com/apache/druid/pull/9356#discussion_r380838094
########## File path: extensions-contrib/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureUtils.java ########## @@ -39,16 +39,25 @@ @VisibleForTesting static final String AZURE_STORAGE_HOST_ADDRESS = "blob.core.windows.net"; + // The azure storage hadoop access pattern is: + // wasb[s]://<containername>@<accountname>.blob.core.windows.net/<path> + // (from https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-hadoop-use-blob-storage) + static final String AZURE_STORAGE_HADOOP_PROTOCOL = "wasbs"; + public static final Predicate<Throwable> AZURE_RETRY = e -> { - if (e instanceof URISyntaxException) { + Throwable t = e; + for (Throwable t2 = e.getCause(); t2 != null; t2 = t2.getCause()) { + t = t2; + } Review comment: test for unraveling a stacktrace. Should we check an unlimited depth? This also changes the current behavior where if the top level throwable was a "retryable" exception, we'd retry, but with this change if a StorageException is caused by a RuntimeException we won't retry. Is this intentional? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
