suneet-s commented on a change in pull request #9356: Add Azure config options
for segment prefix and max listing length
URL: https://github.com/apache/druid/pull/9356#discussion_r380844011
##########
File path:
extensions-core/google-extensions/src/test/java/org/apache/druid/data/input/google/GoogleCloudStorageInputSourceTest.java
##########
@@ -169,14 +175,18 @@ public void testWithPrefixesSplit() throws IOException
public void testReader() throws IOException
{
EasyMock.reset(STORAGE);
+ EasyMock.reset(CONFIG);
addExpectedPrefixObjects(PREFIXES.get(0),
ImmutableList.of(EXPECTED_URIS.get(0)));
addExpectedGetObjectMock(EXPECTED_URIS.get(0));
addExpectedPrefixObjects(PREFIXES.get(1),
ImmutableList.of(EXPECTED_URIS.get(1)));
addExpectedGetObjectMock(EXPECTED_URIS.get(1));
+
EasyMock.expect(CONFIG.getMaxListingLength()).andReturn(EXPECTED_MAX_LISTING_LENGTH);
EasyMock.replay(STORAGE);
+ EasyMock.replay(CONFIG);
Review comment:
nit: looks like this is repeated in multiple tests, maybe move to a helper
function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
