sthetland commented on a change in pull request #6974: sql support for dynamic 
parameters
URL: https://github.com/apache/druid/pull/6974#discussion_r380960896
 
 

 ##########
 File path: docs/querying/sql.md
 ##########
 @@ -55,6 +55,9 @@ like `100` (denoting an integer), `100.0` (denoting a 
floating point value), or
 timestamps can be written like `TIMESTAMP '2000-01-01 00:00:00'`. Literal 
intervals, used for time arithmetic, can be
 written like `INTERVAL '1' HOUR`, `INTERVAL '1 02:03' DAY TO MINUTE`, 
`INTERVAL '1-2' YEAR TO MONTH`, and so on.
 
+Druid SQL supports dynamic parameters using the `?` syntax where parameters 
are bound to `?` in order. Replace any 
+literal with a `?` and supply parameters to the query and the values will be 
bound at execution time.
 
 Review comment:
   Suggestion: This description feels like it could be expanded upon just a 
bit, just to draw out what is meant by "in order," for one thing. How about 
something like:    
   
   "Druid SQL supports dynamic parameters in question mark (`?`) syntax, where 
parameters are bound to the `?` placeholders at execution time. To use dynamic 
parameters, replace any  literal in the query with a `?` character and ensure 
that corresponding parameter values are provided at execution time. Parameters 
are bound to the placeholders in the order in which they are passed."
   
   
      

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to