sthetland commented on a change in pull request #9375: Add support for optional
cloud (aws, gcs, etc.) credentials for s3 for ingestion
URL: https://github.com/apache/druid/pull/9375#discussion_r383535664
##########
File path: docs/ingestion/native-batch.md
##########
@@ -846,6 +847,15 @@ S3 Object:
|bucket|Name of the S3 bucket|None|yes|
|path|The path where data is located.|None|yes|
+Properties Object:
+
+|property|description|default|required?|
+|--------|-----------|-------|---------|
+|accessKeyId|S3 access key for this S3 InputSource|None|yes if secretAccessKey
is given|
+|secretAccessKey|S3 secret key for this S3 InputSource|None|yes if accessKeyId
is given|
+
+**Note :** *If any property is not given in the Properties Object, then the
current default server value will be use.*
Review comment:
```suggestion
Default values are used for any property not overridden in the Properties
Object.
```
Caveat to my edit suggestion: it says "any property" but really it's just S3
access key that are supported, no? To avoid the premature generalization, could
say something like:
"If you don't provide an access key, the default S3 credentials provider
chain is used." (With a link to the relevant section in s3.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
