maytasm3 commented on a change in pull request #9375: Add support for optional
cloud (aws, gcs, etc.) credentials for s3 for ingestion
URL: https://github.com/apache/druid/pull/9375#discussion_r383593983
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSource.java
##########
@@ -76,7 +114,41 @@ protected S3Entity
createEntity(InputSplit<CloudObjectLocation> split)
@Override
public SplittableInputSource<CloudObjectLocation>
withSplit(InputSplit<CloudObjectLocation> split)
{
- return new S3InputSource(s3Client, inputDataConfig, null, null,
ImmutableList.of(split.get()));
+ return new S3InputSource(
+ s3Client.get(),
Review comment:
Not sure what is the correct formatting here.
I do see something like below in the code
`
CloudFilesObject segmentData = new CloudFilesObject(
segmentPath,
outFile,
objectApi.getRegion(),
objectApi.getContainer()
);
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
