suneet-s commented on a change in pull request #9384: Add join prefix
duplicate/shadowing check
URL: https://github.com/apache/druid/pull/9384#discussion_r383979159
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/Joinables.java
##########
@@ -100,6 +112,9 @@ public static boolean isPrefixedBy(final String
columnName, final String prefix)
final JoinableFactory joinableFactory
)
{
+ // Since building a JoinableClause can be expensive, check for prefix
conflicts before building
Review comment:
I think this comment is throwing me off. If building the clause is
expensive, checking for duplicates ahead of time only helps you fail faster at
the cost of correct queries being slightly slower.
I think this needs to be done ahead of time because checking while building
the JoinableClauses is slower than checking ahead of time. Is that correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
