jon-wei commented on a change in pull request #9384: Add join prefix
duplicate/shadowing check
URL: https://github.com/apache/druid/pull/9384#discussion_r384135173
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/Joinables.java
##########
@@ -39,6 +40,16 @@
*/
public class Joinables
{
+ private static final Comparator<String> DESCENDING_LENGTH_STRING_COMPARATOR
= (s1, s2) -> {
+ if (s1.length() > s2.length()) {
+ return -1;
+ } else if (s1.length() < s2.length()) {
+ return 1;
+ } else {
+ return 0;
+ }
+ };
Review comment:
Changed the comparator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
