vogievetsky commented on a change in pull request #9432: Web console: expose 
props for S3
URL: https://github.com/apache/druid/pull/9432#discussion_r386316898
 
 

 ##########
 File path: web-console/src/utils/ingestion-spec.tsx
 ##########
 @@ -1206,6 +1206,30 @@ export function 
getIoConfigFormFields(ingestionComboType: IngestionComboType): F
             </>
           ),
         },
+        {
+          name: 'inputSource.properties.accessKeyId',
+          label: 'Access key ID',
+          type: 'string',
+          placeholder: '(optional)',
+          info: (
+            <>
+              <p>S3 access key for this S3 bucket.</p>
+              <p>Setting this will override the default configuration provided 
in the config.</p>
+            </>
+          ),
+        },
+        {
+          name: 'inputSource.properties.secretAccessKey',
+          label: 'Secret access key',
+          type: 'string',
 
 Review comment:
   is there a way to specify `inputSource.properties.secretAccessKey` to be the 
inline thing but using a JSON object? Something like setting it to `{ "type": 
"inline", "key": "..." }`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to