himanshug commented on a change in pull request #9350: Overlord to support autoscalers per indexer/middlemanager category URL: https://github.com/apache/druid/pull/9350#discussion_r387251212
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/setup/CategorizedWorkerBehaviorConfig.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.overlord.setup; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.druid.indexing.overlord.autoscaling.AutoScaler; +import org.apache.druid.indexing.worker.config.WorkerConfig; + +import java.util.List; +import java.util.Objects; + +/** + * This configuration allows overlord to work with several autoscalers to run tasks of different categories. + */ +public class CategorizedWorkerBehaviorConfig implements WorkerBehaviorConfig +{ + // Use the same category constant as for worker category to match default workers and autoscalers + public static final String DEFAULT_AUTOSCALER_CATEGORY = WorkerConfig.DEFAULT_CATEGORY; + + private final WorkerSelectStrategy selectStrategy; + private final List<AutoScaler> autoScalers; + + @JsonCreator + public CategorizedWorkerBehaviorConfig( Review comment: That means, users who want to use `autoScalers` can't use the console UI to set the spec and would instead have to manually send the http request to coordinator using curl or whatever. after this PR is merged, an issue should be created for console UI updates to make it possible to add `autoScalers` . In this PR, we need to make sure that we stay totally backwards compatible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
