JulianJaffePinterest opened a new pull request #9454: Add OnHeapMemorySegmentWriteOutMediumFactory URL: https://github.com/apache/druid/pull/9454 Add a factory for OnHeapMemorySegmentWriteOutMedium to support direct writing via Spark. ### Description As part of the ongoing discussions on the Druid dev list, Slack channels, and other fora (including #9342), there appears to be significant community desire for writing directly from Spark to Druid. In order to support this, we should expose the ability to write segments using on-heap memory. While less efficient than using off-heap memory, on-heap memory is much easier to manage in Spark and common resource managers (e.g. YARN, Mesos, etc.). This factory is almost exactly the same as the existing OffHeapMemorySegmentWriteOutMediumFactory, with OnHeapMemorySegmentWriteOutMedium substituted for OffHeapMemorySegmentWriteOutMedium. <hr> This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [x] been tested in a test Druid cluster. <hr> ##### Key changed/added classes in this PR * `OnHeapMemorySegmentWriteOutMediumFactory`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
