gianm commented on a change in pull request #9429: fix issue when distinct 
grouping dimensions are optimized into the same virtual column expression
URL: https://github.com/apache/druid/pull/9429#discussion_r389201201
 
 

 ##########
 File path: 
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/DimensionExpression.java
 ##########
 @@ -28,21 +29,55 @@
 
 public class DimensionExpression
 {
+  /**
+   * Create a dimension expresison for direct column access or simple 
extractions
 
 Review comment:
   "expression" (spelling)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to