gianm commented on a change in pull request #9429: fix issue when distinct
grouping dimensions are optimized into the same virtual column expression
URL: https://github.com/apache/druid/pull/9429#discussion_r385253790
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/DimensionExpression.java
##########
@@ -28,6 +28,7 @@
public class DimensionExpression
{
+ private final String inputDimension;
Review comment:
How about `inputColumn`? (I think it's a bit weird to call columns in the
table "dimensions" and would like to get away from that in new code.)
It would also be good to include a comment about what the relationship is
between `inputColumn` and `expression`, with some examples. It might get
confusing to have both. Additionally: if the expression is a simple column
reference, is it required that
`expression.getDirectColumn().equals(inputColumn)`? If so it would be good to
validate that in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
