jon-wei opened a new pull request #9490: Fix NPE when using IndexedTable and all left rows are filtered out URL: https://github.com/apache/druid/pull/9490 This PR fixes an NPE that can occur with joins on RHS tables backed by IndexedTable, where if `IndexedTableJoinMatcher` never gets `reset`, `matchRemainder`, or `matchCondition` called (this can occur when all left rows have been filtered out), the `IndexedTableJoinMatcher` will incorrectly return true for `hasMatch` because the `currentRow` variable was never initialized. This PR initializes `currentRow` in the constructor. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [x] been tested in a test Druid cluster.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
