clintropolis commented on a change in pull request #9516: More efficient join
filter rewrites
URL: https://github.com/apache/druid/pull/9516#discussion_r393263826
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java
##########
@@ -50,73 +51,126 @@
/**
* When there is a filter in a join query, we can sometimes improve
performance by applying parts of the filter
* when we first read from the base table instead of after the join.
- *
- * This class provides a {@link #splitFilter(HashJoinSegmentStorageAdapter,
Set, Filter, boolean, boolean)} method that
- * takes a filter and splits it into a portion that should be applied to the
base table prior to the join, and a
- * portion that should be applied after the join.
- *
+ * <p>
Review comment:
did you mean to put these `<p>` tags?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
