clintropolis commented on a change in pull request #9516: More efficient join 
filter rewrites
URL: https://github.com/apache/druid/pull/9516#discussion_r393241099
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/join/Joinable.java
 ##########
 @@ -89,6 +89,8 @@ JoinMatcher makeJoinMatcher(
   Set<String> getCorrelatedColumnValues(
       String searchColumnName,
       String searchColumnValue,
-      String retrievalColumnName
+      String retrievalColumnName,
+      long maxCorrelationSetSize,
 
 Review comment:
   please update javadoc with new parameters

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to