clintropolis commented on a change in pull request #9525: Azure deep storage
does not work with datasource name containing non-ASCII chars
URL: https://github.com/apache/druid/pull/9525#discussion_r394733243
##########
File path:
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentPusher.java
##########
@@ -186,12 +186,24 @@ DataSegment uploadDataSegment(
final DataSegment outSegment = segment
.withSize(size)
- .withLoadSpec(this.makeLoadSpec(new URI(azurePath)))
+ .withLoadSpec(this.makeLoadSpec(segmentConfig.getContainer(),
azurePath))
.withBinaryVersion(binaryVersion);
log.debug("Deleting file [%s]", compressedSegmentData);
compressedSegmentData.delete();
return outSegment;
}
+
+ private Map<String, Object> makeLoadSpec(String container, String prefix)
Review comment:
Could you make the other `makeLoadSpec` delegate to this method instead of
duplicating it?
```
@Override
public Map<String, Object> makeLoadSpec(URI uri)
{
return makeLoadSpec(segmentConfig.getContainer(), uri.toString());
}
```
Also, is it necessary to pass `container` in since both invocations are
using the same value (if you make the suggested modification)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
