clintropolis commented on a change in pull request #9525: Azure deep storage
does not work with datasource name containing non-ASCII chars
URL: https://github.com/apache/druid/pull/9525#discussion_r395270761
##########
File path:
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentPusher.java
##########
@@ -153,14 +153,7 @@ public DataSegment push(final File indexFilesDir, final
DataSegment segment, fin
@Override
public Map<String, Object> makeLoadSpec(URI uri)
{
- return ImmutableMap.of(
- "type",
- AzureStorageDruidModule.SCHEME,
- "containerName",
- segmentConfig.getContainer(),
- "blobPath",
- uri.toString()
- );
+ return makeLoadSpec(uri.toString());
Review comment:
It looks like hadoop indexing would still call this method so it might have
issues with funny characters, but I don't think it is worth refactoring to fix
the issue at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
